Skip to content

Conversation

@WestLangley
Copy link
Collaborator

Adding a bit more clarification -- both inline and to the docs.

@WestLangley WestLangley added this to the r137 milestone Dec 30, 2021
@WestLangley
Copy link
Collaborator Author

The E2E failure is unrelated to this PR -- I assume.

@Mugen87 Mugen87 changed the title Box3: AABB clarification Docs: Improve Box3 page. Jan 18, 2022
@Mugen87 Mugen87 merged commit 249e041 into mrdoob:dev Jan 18, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jan 21, 2022

Should I revert this now that #20024 got merged?

mrdoob added a commit that referenced this pull request Jan 25, 2022
mrdoob added a commit that referenced this pull request Jan 25, 2022
@WestLangley
Copy link
Collaborator Author

Should I revert this now that #20024 got merged?

@mrdoob I don't think you should have revered it. I think my wording is preferred.

Maybe you can cherry-pick the phrasing you prefer.

@WestLangley WestLangley deleted the dev_aabb_clarification branch February 12, 2022 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants