Fixed uniform sheenRoughness
#23119
Merged
Fixed uniform sheenRoughness
#23119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
Dec 30, 2021
| sheenColor: { value: new Color( 0x000000 ) }, | ||
| sheenColorMap: { value: null }, | ||
| sheenRoughness: { value: 0 }, | ||
| sheenRoughness: { value: 1 }, |
Collaborator
There was a problem hiding this comment.
The exact values do actually not matter. It's only the type which is important so that something like uniform.value.copy() works.
Anyway, for consistency it's probably better to apply the actual default values. You can also update specularIntensity.
Contributor
Author
There was a problem hiding this comment.
correct. i'm extending the MeshPhysicalMaterial to achieve light rim...
Mugen87
approved these changes
Dec 30, 2021
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sheenRoughnessdefaults to 1.0