PLYLoader: Honor different attribute names. #22784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
commented
Nov 4, 2021
|
|
||
| function findAttrName( names ) { | ||
|
|
||
| for ( let i = 0, l = names.length; i < l; i ++ ) { |
Collaborator
Author
There was a problem hiding this comment.
I've noticed that a major part of the performance drop was introduced by the for/in loop. Using a canonical one makes findAttrName() much faster (although the PR still makes the loader a bit slower than before).
Owner
There was a problem hiding this comment.
Some things never change... 😁
I suspect it's okay that is a bit slower.
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: see #22675
Description
Update the original PR with #22675 (comment).