Removed DeviceOrientationControls. #22654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
force-pushed
the
dev17
branch
2 times, most recently
from
9a1e5df to
d774dd8
Compare
Owner
|
Thanks! |
Contributor
|
Just a question : why ? What is the alternative ? (Beside copying the file in my base code) |
Collaborator
Author
|
Sorry, there is no alternative. The class was removed because a reliable implementation across all devices was not possible. It was also not sufficient for a XR fallback. |
Contributor
|
I am baffled by the fact that constructors are not even capable to stick to a single API. |
12 tasks
|
Are there any examples or help with mobile controlling three js scenes? |
Collaborator
Author
|
|
josh8320
pushed a commit
to 345Development/three.js
that referenced
this pull request
Sep 24, 2022
(from commit 1642cdf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: see #22613 (comment)
Description
This PR removes
DeviceOrientationControlsfrom the repository.