Skip to content

Conversation

@sunag
Copy link
Collaborator

@sunag sunag commented Sep 23, 2021

Description

Both Object3D and Material uses .type property to returns the constructor.name.
I think that NodeMaterial can follow this standard.

Renames

  • Node.type -> Node.nodeType
  • Node.getType() -> Node.getNodeType()

New property

  • Node.type -> returns constructor.name

This contribution is funded by Google via Igalia.

@mrdoob mrdoob added this to the r133 milestone Sep 23, 2021
@mrdoob mrdoob merged commit b53dacf into mrdoob:dev Sep 23, 2021
@mrdoob
Copy link
Owner

mrdoob commented Sep 23, 2021

Thanks!

@sunag sunag deleted the dev-nodetype branch September 28, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants