Skip to content

Shaders: renamed some functions #22367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2021
Merged

Shaders: renamed some functions #22367

merged 1 commit into from
Aug 19, 2021

Conversation

@WestLangley
Copy link
Collaborator

@WestLangley WestLangley commented Aug 19, 2021

Having the similarly-name functions getLightProbeIrradiance() and getLightProbeIndirectIrradiance() was too confusing.

The first applies to a LightProbe and the second to an IBL (i.e., environment map).

@WestLangley WestLangley added this to the r132 milestone Aug 19, 2021
@mrdoob mrdoob merged commit aaf7b1e into mrdoob:dev Aug 19, 2021
@mrdoob
Copy link
Owner

mrdoob commented Aug 19, 2021

Thanks!

@WestLangley WestLangley deleted the dev_shaders_nomenclature branch August 19, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r132

Development

Successfully merging this pull request may close these issues.

2 participants

@WestLangley @mrdoob