PMREMGenerator: properly dispose of background material #22338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Aug 16, 2021
Collaborator
|
The change is good assuming |
gkjohnson
approved these changes
Aug 16, 2021
Collaborator
Author
|
Thanks, guys! |
Collaborator
Author
|
@Mugen87 Maybe there is a better way to implement this? |
Collaborator
|
The PR looks good to me! |
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMREMGeneratordoes not dispose of the background material. This PR fixes that.Review requested, please.
/ping @Mugen87
/ping @gkjohnson