Docs: Improve WebXRManager page. #21880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkjohnson
reviewed
May 24, 2021
Collaborator
|
This is related to #21188, as well, which requests a public way to get access to the xr camera and xr viewport resolution. By making this public the individual L and R are now exposed which make the xr viewport information available, too. Is there a clean way to document that do you think? Or perhaps a new XRCamera can be created that documents the extra field added to the L and R cameras? |
Collaborator
Author
|
I'd like to focus this PR on adding the missing methods to the documentation. Please do not continue the discussion of #21188 in this PR. |
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: see #21869
Description
Adds some missing methods to the
WebXRManagerpage.