Skip to content

WebXRController: Convert to ES6 class. #21648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2021
Merged

WebXRController: Convert to ES6 class. #21648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 18 additions & 20 deletions src/renderers/webxr/WebXRController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,16 @@
import { Group } from '../../objects/Group.js';

function WebXRController() {
class WebXRController {

this._targetRay = null;
this._grip = null;
this._hand = null;
constructor() {

}

Object.assign( WebXRController.prototype, {
this._targetRay = null;
this._grip = null;
this._hand = null;

constructor: WebXRController,
}

getHandSpace: function () {
getHandSpace() {

if ( this._hand === null ) {

Expand All @@ -27,9 +25,9 @@ Object.assign( WebXRController.prototype, {

return this._hand;

},
}

getTargetRaySpace: function () {
getTargetRaySpace() {

if ( this._targetRay === null ) {

Expand All @@ -41,9 +39,9 @@ Object.assign( WebXRController.prototype, {

return this._targetRay;

},
}

getGripSpace: function () {
getGripSpace() {

if ( this._grip === null ) {

Expand All @@ -55,9 +53,9 @@ Object.assign( WebXRController.prototype, {

return this._grip;

},
}

dispatchEvent: function ( event ) {
dispatchEvent( event ) {

if ( this._targetRay !== null ) {

Expand All @@ -79,9 +77,9 @@ Object.assign( WebXRController.prototype, {

return this;

},
}

disconnect: function ( inputSource ) {
disconnect( inputSource ) {

this.dispatchEvent( { type: 'disconnected', data: inputSource } );

Expand All @@ -105,9 +103,9 @@ Object.assign( WebXRController.prototype, {

return this;

},
}

update: function ( inputSource, frame, referenceSpace ) {
update( inputSource, frame, referenceSpace ) {

let inputPose = null;
let gripPose = null;
Expand Down Expand Up @@ -238,7 +236,7 @@ Object.assign( WebXRController.prototype, {

}

} );
}


export { WebXRController };