Examples: Fix alignment issue in LUTCubeLoader #21627
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch sets to 1 the unpackAlignment of the DataTexture3D generated by LUTCubeLoader.
There was an issue when LUTCubeLoader is used to load valid 3D .cube files with specific table sizes, the call to gl.texImage3D would fail with the following error: WebGL: INVALID_OPERATION: texImage3D: ArrayBufferView not big enough for request. I specifically noticed the issue with 2x2x2 and 3x3x3 LUT tables.
It should be noted that the issue didn't happen when using the DataTexture (2D) generated by LUTCubeLoader because that class has a default unpackAlignment of 1, unlike DataTexture3D which has a default unpackAlignment of 4. For the sake of clarity, I explicitely set the unpackAlignment to 1 for both the DataTexture and the DataTexture3D in this patch.
/fyi @gkjohnson
Thanks to twitter user KimiruHamiru for the help btw.
Example of a valid 3D .cube file which would trigger the issue :