Skip to content

SSRPass : fixed MAX_STEP #21384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 2, 2021
Merged

SSRPass : fixed MAX_STEP #21384

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9395d72
fixed MAX_STEP
ycw Mar 1, 2021
4592ca0
MAX_STEP toFixed
ycw Mar 1, 2021
342f248
sqrt( a*a+b*b )
ycw Mar 1, 2021
461b102
cast to float; kill `.toFixed`
ycw Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions examples/jsm/postprocessing/SSRPass.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,9 +219,9 @@ var SSRPass = function ( { renderer, scene, camera, width, height, selects, enco
}

this.ssrMaterial = new ShaderMaterial( {
defines: Object.assign( {
MAX_STEP: Math.sqrt( window.innerWidth * window.innerWidth + window.innerHeight * window.innerHeight )
}, SSRShader.defines ),
defines: Object.assign( {}, SSRShader.defines, {
MAX_STEP: Math.sqrt( this.width * this.width + this.height + this.height ).toFixed(1)
Copy link
Contributor

@gonnavis gonnavis Mar 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be multiplication sign here? this.height * this.height

} ),
uniforms: UniformsUtils.clone( SSRShader.uniforms ),
vertexShader: SSRShader.vertexShader,
fragmentShader: SSRShader.fragmentShader,
Expand Down Expand Up @@ -639,7 +639,7 @@ SSRPass.prototype = Object.assign( Object.create( Pass.prototype ), {
this.width = width;
this.height = height;

this.ssrMaterial.defines.MAX_STEP = Math.sqrt( width * width + height * height );
this.ssrMaterial.defines.MAX_STEP = Math.sqrt( width * width + height * height ).toFixed(1);
this.ssrMaterial.needsUpdate = true;
this.beautyRenderTarget.setSize( width, height );
this.prevRenderTarget.setSize( width, height );
Expand Down