Skip to content

Controls: Remove calls of stopPropagation(). #21348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Controls: Remove calls of stopPropagation(). #21348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions examples/js/controls/FirstPersonControls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ THREE.FirstPersonControls = function ( object, domElement ) {
}

event.preventDefault();
event.stopPropagation();

if ( this.activeLook ) {

Expand All @@ -112,7 +111,6 @@ THREE.FirstPersonControls = function ( object, domElement ) {
this.onMouseUp = function ( event ) {

event.preventDefault();
event.stopPropagation();

if ( this.activeLook ) {

Expand Down
2 changes: 0 additions & 2 deletions examples/js/controls/FlyControls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ THREE.FlyControls = function ( object, domElement ) {
}

event.preventDefault();
event.stopPropagation();

if ( this.dragToLook ) {

Expand Down Expand Up @@ -158,7 +157,6 @@ THREE.FlyControls = function ( object, domElement ) {
this.mouseup = function ( event ) {

event.preventDefault();
event.stopPropagation();

if ( this.dragToLook ) {

Expand Down
2 changes: 0 additions & 2 deletions examples/js/controls/OrbitControls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,7 +989,6 @@ THREE.OrbitControls = function ( object, domElement ) {
if ( scope.enabled === false || scope.enableZoom === false || ( state !== STATE.NONE && state !== STATE.ROTATE ) ) return;

event.preventDefault();
event.stopPropagation();

scope.dispatchEvent( startEvent );

Expand Down Expand Up @@ -1098,7 +1097,6 @@ THREE.OrbitControls = function ( object, domElement ) {
if ( scope.enabled === false ) return;

event.preventDefault(); // prevent scrolling
event.stopPropagation();

switch ( state ) {

Expand Down
5 changes: 0 additions & 5 deletions examples/js/controls/TrackballControls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,6 @@ THREE.TrackballControls = function ( object, domElement ) {
function onMouseDown( event ) {

event.preventDefault();
event.stopPropagation();

if ( _state === STATE.NONE ) {

Expand Down Expand Up @@ -539,7 +538,6 @@ THREE.TrackballControls = function ( object, domElement ) {
if ( scope.enabled === false ) return;

event.preventDefault();
event.stopPropagation();

var state = ( _keyState !== STATE.NONE ) ? _keyState : _state;

Expand All @@ -565,7 +563,6 @@ THREE.TrackballControls = function ( object, domElement ) {
if ( scope.enabled === false ) return;

event.preventDefault();
event.stopPropagation();

_state = STATE.NONE;

Expand All @@ -583,7 +580,6 @@ THREE.TrackballControls = function ( object, domElement ) {
if ( scope.noZoom === true ) return;

event.preventDefault();
event.stopPropagation();

switch ( event.deltaMode ) {

Expand Down Expand Up @@ -646,7 +642,6 @@ THREE.TrackballControls = function ( object, domElement ) {
if ( scope.enabled === false ) return;

event.preventDefault();
event.stopPropagation();

switch ( event.touches.length ) {

Expand Down
2 changes: 0 additions & 2 deletions examples/jsm/controls/FirstPersonControls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ var FirstPersonControls = function ( object, domElement ) {
}

event.preventDefault();
event.stopPropagation();

if ( this.activeLook ) {

Expand All @@ -118,7 +117,6 @@ var FirstPersonControls = function ( object, domElement ) {
this.onMouseUp = function ( event ) {

event.preventDefault();
event.stopPropagation();

if ( this.activeLook ) {

Expand Down
2 changes: 0 additions & 2 deletions examples/jsm/controls/FlyControls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ var FlyControls = function ( object, domElement ) {
}

event.preventDefault();
event.stopPropagation();

if ( this.dragToLook ) {

Expand Down Expand Up @@ -164,7 +163,6 @@ var FlyControls = function ( object, domElement ) {
this.mouseup = function ( event ) {

event.preventDefault();
event.stopPropagation();

if ( this.dragToLook ) {

Expand Down
2 changes: 0 additions & 2 deletions examples/jsm/controls/OrbitControls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -999,7 +999,6 @@ var OrbitControls = function ( object, domElement ) {
if ( scope.enabled === false || scope.enableZoom === false || ( state !== STATE.NONE && state !== STATE.ROTATE ) ) return;

event.preventDefault();
event.stopPropagation();

scope.dispatchEvent( startEvent );

Expand Down Expand Up @@ -1108,7 +1107,6 @@ var OrbitControls = function ( object, domElement ) {
if ( scope.enabled === false ) return;

event.preventDefault(); // prevent scrolling
event.stopPropagation();

switch ( state ) {

Expand Down
5 changes: 0 additions & 5 deletions examples/jsm/controls/TrackballControls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,6 @@ var TrackballControls = function ( object, domElement ) {
function onMouseDown( event ) {

event.preventDefault();
event.stopPropagation();

if ( _state === STATE.NONE ) {

Expand Down Expand Up @@ -547,7 +546,6 @@ var TrackballControls = function ( object, domElement ) {
if ( scope.enabled === false ) return;

event.preventDefault();
event.stopPropagation();

var state = ( _keyState !== STATE.NONE ) ? _keyState : _state;

Expand All @@ -573,7 +571,6 @@ var TrackballControls = function ( object, domElement ) {
if ( scope.enabled === false ) return;

event.preventDefault();
event.stopPropagation();

_state = STATE.NONE;

Expand All @@ -591,7 +588,6 @@ var TrackballControls = function ( object, domElement ) {
if ( scope.noZoom === true ) return;

event.preventDefault();
event.stopPropagation();

switch ( event.deltaMode ) {

Expand Down Expand Up @@ -654,7 +650,6 @@ var TrackballControls = function ( object, domElement ) {
if ( scope.enabled === false ) return;

event.preventDefault();
event.stopPropagation();

switch ( event.touches.length ) {

Expand Down