Skip to content

Conversation

@marcofugaro
Copy link
Contributor

Related issue: #20009 (comment)

Description

Eslint also needs to know about babel to support class properties.
In this PR I added @babel/eslint-parser as a parser for eslint. This does not change the current eslint bahaviour.

I also put the babelrc in a custom file babel.config.js because it's needed for eslint and removed an unused String.prototype.replaceAll()

@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 9, 2021

Related: #21170 (comment)

@mrdoob mrdoob added this to the r126 milestone Feb 9, 2021
@mrdoob mrdoob merged commit 006c128 into mrdoob:dev Feb 9, 2021
@mrdoob
Copy link
Owner

mrdoob commented Feb 9, 2021

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Feb 9, 2021

This broke ESLint for me:

Screen Shot 2021-02-09 at 2 51 34 PM

I tried doing npm update and npm install.

@mrdoob
Copy link
Owner

mrdoob commented Feb 9, 2021

This is blocking me. I'll have to revert.

@marcofugaro
Copy link
Contributor Author

@mrdoob is that your editor? What happens if you do npm run lint-fix? On my machine it runs eslint just fine

@mrdoob
Copy link
Owner

mrdoob commented Feb 9, 2021

Yep, it's Atom. I'll try later tonight.

@marcofugaro
Copy link
Contributor Author

marcofugaro commented Feb 9, 2021

Okay, I'll do a new configuration which doesn't involve that ./utils/build/babel.config.json path thing, let me know if that works for you when you'll try it later!

Edit: done!

@mrdoob mrdoob removed this from the r126 milestone Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants