VRMLLoader: Adding names of nodes. #21210
Conversation
For the itentification of the element the name is helpful. VRML: DEF ring Transform ->"ring" geometry.name=node.DEF; for buildIndexedFaceSetNode for buildGroupingNode
|
|
||
| } | ||
|
|
||
| object.name=node.DEF; |
There was a problem hiding this comment.
Please note that DEF is optional so it can be undefined and thus Object3D.name. This is not good.
I suggest you change the lines to this pattern:
if ( node.DEF !== undefined ) object.name = node.DEF;There was a problem hiding this comment.
Yes.
Is there anything else I need to do here - I'm not that familiar with github?
There was a problem hiding this comment.
The idea is that you push an additional commit with the requested changes.
There was a problem hiding this comment.
Maybe he did the PR from the website?
There was a problem hiding this comment.
@polygontwist If okay for you, I can do this change tomorrow. Otherwise I suggest you fork the repository, applying your changes in a new branch and then make a PR. So the typical contribution workflow.
|
Please change the file |
|
I think it makes sense to enhance |
|
Closing in favor of #21217. |
3 participants
Description
For the itentification of the element the name is helpful.
VRML: DEF ring Transform ->"ring"
geometry.name=node.DEF;
for buildIndexedFaceSetNode
for buildGroupingNode