Skip to content

WebGPU: All UBOs and varys is generate by nodes #21170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 2, 2021
Merged

WebGPU: All UBOs and varys is generate by nodes #21170

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b8c2a26
cleanup
sunag Jan 29, 2021
d217cfa
WVPNode and updates
sunag Jan 29, 2021
5922e92
use PositionNode for colors
sunag Jan 31, 2021
8fc611e
cleanup example
sunag Jan 31, 2021
5a57795
cleanup
sunag Jan 31, 2021
146036f
fix name WVP -> MVP
sunag Jan 31, 2021
88b61bb
renamed MVPNode to GLPositionNode
sunag Jan 31, 2021
d0ca03d
fix code style
sunag Jan 31, 2021
e432081
fix code style(2)
sunag Jan 31, 2021
5f97672
fix operator
sunag Jan 31, 2021
f54dca8
fix equality
sunag Jan 31, 2021
ce02271
not use getDataFromNode for now
sunag Jan 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/jsm/renderers/nodes/accessors/CameraNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,13 @@ class CameraNode extends Node {

if ( scope === CameraNode.PROJECTION || scope === CameraNode.VIEW ) {

if ( !inputNode || !inputNode.isMatrix4Node ) {
if ( !inputNode || !inputNode.isMatrix4Node !== true ) {

inputNode = new Matrix4Node( null );

}

} else if ( !inputNode || !inputNode.isVector3Node ) {
} else if ( !inputNode || !inputNode.isVector3Node !== true ) {

inputNode = new Vector3Node();

Expand Down