Mesh: Remove dependency to Face3. #21161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Sounds good! 👍 |
Owner
|
Thanks! |
|
Documentation does not reflect change. Very confusing for beginners. |
Owner
How so? This change has not been released yet. |
Collaborator
Author
This change landed in |
Owner
|
Ah right... Ops... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
Instead of using
Face3,Mesh.raycast()now creates custom objects for faces.I'd like to suggest this change since
Face3was originally related toGeometry. Besides, it seemsMeshis the only place in the core and examples which usesFace3. If this PR is merged, we could consider to move theFace3definition intoexamples/jsm/deprecated/Geometry.js.