Skip to content

Color: Fix ReDoS in setStyle #21143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 25, 2021
Merged

Color: Fix ReDoS in setStyle #21143

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35f9d33
Color: Fix ReDoS in setStyle
yetingli Jan 25, 2021
8fe30a5
Fix ReDoS
yetingli Jan 25, 2021
0f5de4f
Fix ReDos in Color.js
yetingli Jan 25, 2021
4a58235
Fix ReDoS
yetingli Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/math/Color.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,13 +163,13 @@ class Color {

let m;

if ( m = /^((?:rgb|hsl)a?)\(\s*([^\)]*)\)/.exec( style ) ) {
if ( m = /^((?:rgb|hsl)a?)\(([^\)]*)\)/.exec( style ) ) {

// rgb / hsl

let color;
const name = m[ 1 ];
const components = m[ 2 ];
const components = m[ 2 ].replace(/^\s*/, '');

switch ( name ) {

Expand Down