-
-
Notifications
You must be signed in to change notification settings - Fork 36.1k
Added USDZExporter #21096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added USDZExporter #21096
Conversation
|
@101arrowz I had to add the full |
|
Alright, let me know if you want a custom build and I'll make another one. |
|
I think it'll be best to remove the custom builds and just have the build that has everything. |
|
Sounds good. For people using in production, you might want to make a script for creating a minified build by running through |
|
I've tried different models but after exporting in USDZ they all look too dark in Quick View. Adding metallic map (all black or white) does not solve the problem. Do you experience the same "too dark" problem? |
|
@kolodi Can you share the files you're having issues with? |
https://tinyurl.com/yh6y649y pure white appears as a grey one, and all materials are darker, like there is some bias for all them. |
|
@qeeqez any chance you can investigate the issue? |
|
@mrdoob I'll have a look on it. I have an opposite problem - my materials are too bright in Quick Look 😅 |
|
Did you have a chance to look at the models? |
|
Having a look at it today. |
|
Unrelated... Seems like USD doesn't support |
These export correctly. We're matching Apple's own usdzconvert: |
|
@kolodi sorry for long answer, pretty busy this week. I've checked yours models. Looks like this "grayish" is not a problem of the model but of the lighting in AR QuickLook which we couldn't change. For my issue (too light color): it seems to be that I've used SRGB colors instead of Linear ones for the models. And also lighting changes my colors a little bit. I'm further investigating this issue. |
I have checked everything we can do in QuickLook and, yes, we can't control anything like lighting, there is a reflection (environment) map created dynamically (which is pretty cool) but overall it makes models darker.
Very interesting. I was playing around :sourceColorSpace: three.js/examples/jsm/exporters/USDZExporter.js Lines 110 to 118 in d379666
|
|
The issue with this file is the fact that we don't export |
I was also using usdzexport tool to compare results. materials and texture definitions are structured differently (I'm currently working to change the structure for USDZExporter as well) but the visual result is the same. When opening in xCode converted usdz looks fine, but in QuickLook lighting makes them too dark. I was trying on 2 devices. On older iPad they are just darker, but on latest and greatest iPhone with lidar models look even more darker. |


Related issue: #14219
Description
First version of the USDZ exporter:
I've also added it to the editor so it's easier to try different models.