Skip to content

Conversation

@takahirox
Copy link
Collaborator

@takahirox takahirox commented Dec 18, 2020

Related issue: #20795 (comment)

Background

Currently the examples unit tests are run only on http://localhost:8080/test/unit/UnitTests.html and there are no npm command to run them on Node.js.

Suggestion

I'd like to suggest to add a npm command to run the examples unit tests because it would be helpful for the quick tests.

Changes

I haven't let the root npm run test command invoke npm run test-unit-examples yet because I'm on the fence about it.

Screenshot

image

It shows npm run test-unit-examples works. As you see the examples unit tests cause console warnings similar to #20760. I hope we can remove them in another PR.

This contribution is made at a hotel where I stay for quarantines.

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 18, 2020

This contribution is made at a hotel where I stay for quarantines.

Hope you stay safe!

@mrdoob mrdoob added this to the r124 milestone Dec 21, 2020
@mrdoob mrdoob merged commit 606b7f0 into mrdoob:dev Dec 21, 2020
@mrdoob
Copy link
Owner

mrdoob commented Dec 21, 2020

Thanks!

@takahirox takahirox deleted the ExampleUnitTest branch December 21, 2020 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants