Skip to content

Rendering fix for degenerate UVs #18871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Rendering fix for degenerate UVs #18871

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32405bd
Rendering fix for degenerate UVs
elalish Mar 11, 2020
9f4efff
fix formatting
elalish Mar 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/renderers/shaders/ShaderChunk/normalmap_pars_fragment.glsl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@ export default /* glsl */`

float scale = sign( st1.t * st0.s - st0.t * st1.s ); // we do not care about the magnitude

// This avoids NaNs with degenerate UV coordinates
if ( scale == 0.0 ) {

return normalize( surf_norm );

}

vec3 S = normalize( ( q0 * st1.t - q1 * st0.t ) * scale );
vec3 T = normalize( ( - q0 * st1.s + q1 * st0.s ) * scale );
vec3 N = normalize( surf_norm );
Expand Down