Skip to content

FullScreenQuad: Introduce dispose(). #18150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrdoob merged 1 commit into from
Dec 13, 2019
Merged

FullScreenQuad: Introduce dispose(). #18150

mrdoob merged 1 commit into from
Dec 13, 2019

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Dec 13, 2019

@mrdoob
Copy link
Owner

mrdoob commented Dec 13, 2019

Does this conflict with #18149?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Dec 13, 2019 •
edited
Loading

It's more or less the actual fix. Otherwise you would have to access a private member of FullScreenQuad in order to release the internal geometry. With dispose(), it's much nicer.

@mrdoob
Copy link
Owner

mrdoob commented Dec 13, 2019

But, I mean. Should I revert #18149?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Dec 13, 2019

I think just merging this PR is okay. I've merged #18149 so @drcmda could directly work with dev without waiting on my PR 😇

@mrdoob mrdoob added this to the r112 milestone Dec 13, 2019
@mrdoob mrdoob merged commit b0a1e8c into mrdoob:dev Dec 13, 2019
@mrdoob
Copy link
Owner

mrdoob commented Dec 13, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r112

Development

Successfully merging this pull request may close these issues.

2 participants

@Mugen87 @mrdoob