Skip to content

Revert Adreno double-sided front-facing workaround #17958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Revert Adreno double-sided front-facing workaround #17958

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions src/renderers/shaders/ShaderChunk/normalmap_pars_fragment.glsl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,21 +32,10 @@ export default /* glsl */`
vec3 T = normalize( ( - q0 * st1.s + q1 * st0.s ) * scale );
vec3 N = normalize( surf_norm );

#ifdef DOUBLE_SIDED

// Workaround for Adreno GPUs gl_FrontFacing bug. See #15850 and #10331

bool frontFacing = dot( cross( S, T ), N ) > 0.0;

mapN.xy *= ( float( frontFacing ) * 2.0 - 1.0 );

#else

mapN.xy *= ( float( gl_FrontFacing ) * 2.0 - 1.0 );
mat3 tsn = mat3( S, T, N );

#endif
mapN.xy *= ( float( gl_FrontFacing ) * 2.0 - 1.0 );

mat3 tsn = mat3( S, T, N );
return normalize( tsn * mapN );

}
Expand Down