Layers for WebVR #17718
Closed
Layers for WebVR #17718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
Collaborator
|
Better to create a new PR targeting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the VR camera was hardcoded to only show layer 0 and 1 in the left eye, and layer 0 and 2 in the right eye. Because of this, layers were unusable since the layers set on the original perspective camera was not carried over to the new VR camera.
This is very confusing if you do not know about this since it simply seems like layers are broken in VR mode. Most people using this functionality probably want to use layers normally and not render different views for different eyes. If they do, they will now have to use the new leftLayers and rightLayers fields.