DRAFT: getProgramCode to getProgramHashCode #16674
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
If so, consider to make Draft PRs in the future (e.g. #16678) |
sunag
changed the title
WestLangley
reviewed
Jun 4, 2019
src/renderers/WebGLRenderer.js
Outdated
| material, lights.state, shadowsArray, fog, _clipping.numPlanes, _clipping.numIntersection, object ); | ||
|
|
||
| var code = programCache.getProgramCode( material, parameters ); | ||
| var checksum = programCache.getProgramChecksum( material, parameters ); |
Collaborator
There was a problem hiding this comment.
The crc is used as a hash, so maybe use this terminology, instead?
var hash = programCache.getProgramHashCode( material, parameters );
Collaborator
|
@sunag The idea is great but we need a performance test to verify the consequences on memory consumption and processing speed. The performance of Closing for now. Please make a new (non-WIP) PR if you can confirm no performance degradation in |
Mugen87
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a reduction in memory usage since the whole code is stored in a string as a hash.
Still, a benchmark is required to check the memory usage reduction and additional processing used to generate the checksum.
It is a WIP - not ready for merger