Skip to content

Update vr drawing buffer size when the WebVRManager device is set. #16015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update vr drawing buffer size when the WebVRManager device is set. #16015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 31 additions & 15 deletions src/renderers/webvr/WebVRManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,27 +65,14 @@ function WebVRManager( renderer ) {

function onVRDisplayPresentChange() {

if ( isPresenting() ) {

var eyeParameters = device.getEyeParameters( 'left' );
var renderWidth = eyeParameters.renderWidth * framebufferScaleFactor;
var renderHeight = eyeParameters.renderHeight * framebufferScaleFactor;
updateDrawingBufferSize();
Copy link
Contributor Author

@dmarcos dmarcos Mar 19, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Factor out drawing buffer resizing logic and call it.


currentPixelRatio = renderer.getPixelRatio();
renderer.getSize( currentSize );

renderer.setDrawingBufferSize( renderWidth * 2, renderHeight, 1 );
if ( isPresenting() ) {

animation.start();

} else {

if ( scope.enabled ) {

renderer.setDrawingBufferSize( currentSize.width, currentSize.height, currentPixelRatio );

}

animation.stop();

}
Expand Down Expand Up @@ -119,6 +106,31 @@ function WebVRManager( renderer ) {

}

function updateDrawingBufferSize() {
Copy link
Contributor Author

@dmarcos dmarcos Mar 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same logic previously contained in the onVRDisplayPresentChange handler


if ( isPresenting() ) {

var eyeParameters = device.getEyeParameters( 'left' );
var renderWidth = eyeParameters.renderWidth * framebufferScaleFactor;
var renderHeight = eyeParameters.renderHeight * framebufferScaleFactor;

renderer.setDrawingBufferSize( renderWidth * 2, renderHeight, 1 );

} else {

if ( scope.enabled ) {

currentPixelRatio = renderer.getPixelRatio();
renderer.getSize( currentSize );

renderer.setDrawingBufferSize( currentSize.width, currentSize.height, currentPixelRatio );

}

}

}

function updateControllers() {

for ( var i = 0; i < controllers.length; i ++ ) {
Expand Down Expand Up @@ -210,6 +222,10 @@ function WebVRManager( renderer ) {

animation.setContext( value );

updateDrawingBufferSize();

if ( isPresenting() ) animation.start();
Copy link
Contributor Author

@dmarcos dmarcos Mar 19, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start animation. If vrdisplaypresentchange fires after requestPresent and no device has been set the render loop never kicks off.


};

this.setFramebufferScaleFactor = function ( value ) {
Expand Down