Concatenated strings to template strings #15516
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I was not aware you were talking about the examples folder. With this change a bunch of examples will stop working in oldish browsers. |
mrdoob
reviewed
Jan 7, 2019
| import { NodeLib } from './NodeLib.js'; | ||
|
|
||
| var declarationRegexp = /^([a-z_0-9]+)\s([a-z_0-9]+)\s*\((.*?)\)/i, | ||
| var declarationRegexp = /^(?:(?:\s*\/\/.*?\n)*)\s*([a-z_0-9]+)\s([a-z_0-9]+)\s*\((.*?)\)/i, |
Owner
There was a problem hiding this comment.
Do you mind explaining this regexp change? Is it to handle tabs and comments?
Contributor
There was a problem hiding this comment.
Do you mind explaining this regexp change? Is it to handle tabs and comments?
This ignores line comments before function declaration.
Contributor
There was a problem hiding this comment.
Without this,
new FunctionNode( /* glsl */`
// https://stackoverflow.com/questions/36174431/how-to-make-a-wave-warp-effect-in-shader
vec2 sineWave(vec2 uv, vec2 phase) {
// wave distortion
float x = sin( 25.0*uv.y + 30.0*uv.x + 6.28*phase.x) * 0.01;
float y = sin( 25.0*uv.y + 30.0*uv.x + 6.28*phase.y) * 0.03;
return vec2(uv.x+x, uv.y+y);
}
`);would be broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15506