-
-
Notifications
You must be signed in to change notification settings - Fork 36.1k
ColladaExporter: Optimize material export and added example #15469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d, changed material to get number of materials from the material array instead of the empty geometry.groups array and added an example for the changes
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <title>three.js webgl - teapot buffer geometry</title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<title>three.js webgl - collada exporter</title>and probably rename file to misc_exporter_collada.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the 2 changes above and just noticed the files.js
Should I add this to the "misc" section of the list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, otherwise the example won't be visible on the overview page: https://threejs.org/examples/
…he file from webgl_geometry_teapot_collada.html to misc_exporter_collada.html
|
/cc @gkjohnson |
|
This looks good to me -- my only comment is that it seems like the |
I think this can still be done in a separate PR. |
|
Thanks! |
ColladaExporter material bugs:
was using groups to determine material count, in my tests the group count was always zero resulting in no material export
changed to take the largest value between the group and material counts
removed incompatible tags on collada shaders - https://www.khronos.org/files/collada_spec_1_4.pdf
constant shader does not have diffuse, shininess or specular tags
lambert shader does not have shininess or specular tags
added web page to demo the changes