-
-
Notifications
You must be signed in to change notification settings - Fork 36.1k
Pass XRFrame reference to client render loop. #15290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Let me know if you there's anything pending. Happy to accommodate any changes. |
|
+1 |
|
@mrdoob Let me know if there's any changes you want here. Thanks. |
|
The idea is that |
|
I need a reference as well for hit testing and pose as @dmarcos mentioned. Right now the only way I found was to fork and pass the frame as well along the current time parameter to Is there eventually another way? |
|
WebVRManager has been deprecated. API inconsistency with WebXRManager should be no longer an issue. |
|
Yep! Do you mind resolving the conflicts? |
|
rebased |
|
Thanks! |
|
Thanks for the quick turnaround |
A-Frame handles controllers externally and is needed to query their pose.