Skip to content

Conversation

@dmarcos
Copy link
Contributor

@dmarcos dmarcos commented Nov 21, 2018

A-Frame handles controllers externally and is needed to query their pose.

@dmarcos dmarcos mentioned this pull request Nov 21, 2018
3 tasks
@dmarcos
Copy link
Contributor Author

dmarcos commented Jan 8, 2019

Let me know if you there's anything pending. Happy to accommodate any changes.

@tlaukkan
Copy link

+1

@dmarcos
Copy link
Contributor Author

dmarcos commented Mar 24, 2019

@mrdoob Let me know if there's any changes you want here. Thanks.

@mrdoob
Copy link
Owner

mrdoob commented Jun 20, 2019

The idea is that WebVRManager and WebXRManager should expose the same API so the user doesn't need to worry about what API is being used underneath. We should find a way to provide the same functionality with both.

@vedtam
Copy link

vedtam commented Dec 13, 2019

I need a reference as well for hit testing and pose as @dmarcos mentioned. Right now the only way I found was to fork and pass the frame as well along the current time parameter to onAnimationFrameCallback:

https://github.com/vedtam/three.js/blob/079638270a33de8779b0abd2a790d4659444dc23/src/renderers/webxr/WebXRManager.js#L358

Is there eventually another way?
Thanks.

@dmarcos
Copy link
Contributor Author

dmarcos commented Dec 13, 2019

WebVRManager has been deprecated. API inconsistency with WebXRManager should be no longer an issue.

@mrdoob
Copy link
Owner

mrdoob commented Dec 13, 2019

Yep! Do you mind resolving the conflicts?

@mrdoob mrdoob added this to the r112 milestone Dec 13, 2019
@dmarcos
Copy link
Contributor Author

dmarcos commented Dec 13, 2019

rebased

@mrdoob mrdoob merged commit ef1cd64 into mrdoob:dev Dec 13, 2019
@mrdoob
Copy link
Owner

mrdoob commented Dec 13, 2019

Thanks!

@dmarcos
Copy link
Contributor Author

dmarcos commented Dec 13, 2019

Thanks for the quick turnaround

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants