Instanced Mesh [TSL/WebGPU] - Crashout Inside WebGPURenderer Logic

[Bug-Reaper]

Description

Good news guys, I'm finding all the TSL edge-cases 😂. Custom Geometry with MorphAttributes causes some edge-case error with InstancedMesh.

Big Error loop from the renderer once the instancedMesh is added to scene.

SES_UNHANDLED_REJECTION: TypeError: sphere is undefined
    copy three.core.js:10141
    computeBoundingSphere three.core.js:25482
    ....
SES_UNCAUGHT_EXCEPTION: TypeError: geometry.boundingSphere is undefined
    _projectObject three.webgpu.js:52789
    _projectObject three.webgpu.js:52847
    _projectObject three.webgpu.js:52847
    _renderScene three.webgpu.js:51553
    render three.webgpu.js:51338
    ....

Reproduction steps

1. Created several geometries from scratch using a catmull3 and TubeGeometry
2. Created a combined root geometry with two morphTargets.
3. Created a dummy-mesh for InstancedMesh() generation.
4. WebGPURenderer Crashes out if instancedMesh is added.

Not doing anything drastically different from the instancingMorph webGPU example. Edge-case vibes IMO.

Code

All the really relevant code is in the fiddle. Notable we only crashout if the instancedMesh is added to the scene, the root mesh can be added on it's own and everything renders fine.

    // SEE HERE!!!
    // We crashout if we add the instancedMesh 
    // Works fine if we only add the dummy Mesh 
    // (dummy mesh is used for construction of the InstancedMesh)

    scene.add(instancedM)
    //scene.add(dummy)

Live example

https://jsfiddle.net/s6ado1g9/1/

Screenshots

This is what the core-mesh looks like. It's a hopf fibration with morphtargets for different states.

Version

r176

Device

Desktop

Browser

Firefox, Chrome

OS

MacOS

[Bug-Reaper]

Issue was mostly between the chair and keyboard. I may PR a warning if you pass a non-geometry as the first arg InstancedMesh()

✅ -> const ll = new THREE.InstancedMesh( dummy.geometry, tubeMaterial, ringers );
❌ -> const ll = new THREE.InstancedMesh( dummy, tubeMaterial, ringers );

[WestLangley]

I may PR a warning if you pass a non-geometry as the first arg InstancedMesh()

three.js does not validate inputs. Please be more careful.

[Bug-Reaper]

I may PR a warning if you pass a non-geometry as the first arg InstancedMesh()

three.js does not validate inputs. Please be more careful.

Thanks @WestLangley 👍 I'm genuinely curious is there a longer policy or something? THREE.js has warnings and you mean to tell me none of them are input related, that doesn't sound right? I know there have been times in a long history of usage that a warning somewhere saved me, possible I'm remembering some of the utility scripts though.

On this topic; if not in the constructor perhaps input-validation is can be handled in the debugger extension 🤔

[WestLangley]

@Bug-Reaper It's true, three.js validates inputs if there has been an API change and validation seems prudent.

Otherwise, input validation is your app's responsibility.

[Bug-Reaper]

Thank you for the clarification west 🙏

On the topic of input-related errors, it smells like there's a good opportunity to validate most inputs in the debugger extension and warn accordingly? Needs investigation.

[Bug-Reaper]

@WestLangley I generally agree that excessive input validation sucks.

Got particularly tripped up here b/c you get other errors with valid inputs unless you do undocumented additional manual setup:

Undocumented InstancedMesh Setup TSL

You must setMorphAt() for at least one index before the renderer tries to draw the instancedMesh.

SES_UNCAUGHT_EXCEPTION: TypeError: ll.morphTexture is null

Confusingly and redundantly? You must manually create morphTargetInfluences prop on the instanced mesh. This should probably be handled by the constructor?

instancedMesh["morphTargetInfluences"]=[0,1]
// It also doesn't make sense in the context of how instancedMeshes work?

Otherwise Error:

Uncaught (in promise) TypeError: this.mesh.morphTargetInfluences is undefined

[WestLangley]

@Bug-Reaper I believe @Mugen87 can provide an official response to these suggestions, and make decisions on policy changes.

/ping @Mugen87

[Mugen87]

Do you mind creating a live example that shows what's confusing?