make_lib_rust - use position independent code #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mratsim
previously approved these changes
Jan 9, 2024
Owner
mratsim
left a comment
mratsim
left a comment
There was a problem hiding this comment.
Thank you!
I would have done something similar.
Owner
|
Seems like on Windows, |
mratsim
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added -fPIC when using make_lib_rust, since rust already does that by default.
This change is required by rust-kzg constantine backend to make c-kzg-4844 bindings work.
@mratsim if enabling for all rust builds is not acceptable, I can also add as optional feature in Cargo.toml & change how it's passed in build.rs
I am not familiar with Nim so if there's a better/more preferred way of doing this lmk, will be happy to fix.