Skip to content

Display sample points on the line chart #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BinderDavid merged 1 commit into from
Oct 13, 2019
Merged

Display sample points on the line chart #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
* Line chart now displays points for each sample so it's easier to see where to hover.

0.5, released 2019-10-11

* Add some more metainformation to the header (sample mode and sample interval)
Expand Down
2 changes: 1 addition & 1 deletion src/Eventlog/VegaTemplate.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ linesLayer c = asSpec
VL.width (0.9 * cwidth c),
VL.height (0.7 * cheight c),
dataFromSource "data_json_samples" [],
VL.mark Line [],
VL.mark Line [MPoint (PMMarker [])],
encodingLineLayer c [],
transformLineLayer []
]
Expand Down