Skip to content

Critical points#243

Merged
mphoward merged 13 commits intomainfrom
issue-52
May 9, 2025
Merged

Critical points#243
mphoward merged 13 commits intomainfrom
issue-52

Conversation

@mmm0226
Copy link
Copy Markdown
Contributor

@mmm0226 mmm0226 commented May 7, 2025 •
edited by mphoward
Loading

New content

Resolves #52

Checklist

  • New pages are added to the table of contents.
  • Everything displays correctly in the web-generated preview.
  • Appropriate attribution has been given to source materials.
  • My name is included alphabetically in credits.md.

@mmm0226 mmm0226 linked an issue May 7, 2025 that may be closed by this pull request
critical point for 2d system #52
Closed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2025 •
edited
Loading

PR Preview Action v1.6.1
Preview removed because the pull request was closed.
2025-05-09 19:06 UTC

@mmm0226 mmm0226 requested a review from mphoward May 8, 2025 22:49
@mmm0226
Copy link
Copy Markdown
Contributor Author

mmm0226 commented May 8, 2025

I took screenshots of the drawings in the notes and tried to add them to the images file but it wouldn't work. They started out as png and I even converted them to jpg but I was still not able to add them.

mphoward
mphoward requested changes May 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mphoward mphoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images corresponding to these critical points haven't been uploaded. Could you please commit them if you'd like us to help you format them on the page?

@mmm0226
Copy link
Copy Markdown
Contributor Author

mmm0226 commented May 9, 2025

I took screenshots of the drawings in the notes and tried to add them to the images file but it wouldn't work. They started out as png and I even converted them to jpg but I was still not able to add them.

@mphoward
Copy link
Copy Markdown
Contributor

mphoward commented May 9, 2025

Please email me your images ASAP, and I'll help you add them.

@mphoward mphoward changed the title Issue 52 Critical points May 9, 2025
mphoward
mphoward approved these changes May 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mphoward mphoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I uploaded these files and formatted them, so you should be all set.

@mphoward mphoward merged commit a32952a into main May 9, 2025
2 checks passed
@mphoward mphoward deleted the issue-52 branch May 9, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mphoward mphoward mphoward approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

critical point for 2d system

2 participants

@mmm0226 @mphoward