Skip to content

Update GitHub Actions' workflows#20

Merged
mpeteuil merged 2 commits intompeteuil:mainfrom
nnsnodnb:update-ci
Nov 12, 2023
Merged

Update GitHub Actions' workflows#20
mpeteuil merged 2 commits intompeteuil:mainfrom
nnsnodnb:update-ci

Conversation

@nnsnodnb
Copy link
Copy Markdown
Contributor

@nnsnodnb nnsnodnb commented Nov 2, 2023

  • Updated steps.
  • Improved getting full python version from actions/setup-python@4.
  • set-output was deprecate.
  • poetry install added --sync argument.

Thank you!

Copy link
Copy Markdown
Owner

@mpeteuil mpeteuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nnsnodnb! Thanks for the contributions to update these deprecations! There's one change that needs to be made, otherwise this looks.

@nnsnodnb nnsnodnb requested a review from mpeteuil November 11, 2023 06:38
@mpeteuil
Copy link
Copy Markdown
Owner

Thanks @nnsnodnb. The reason this was failing was outlined and resolved in #21. If you either rebase against main or merge main into these changes then these tests should run as expected and we can get your contributions merged 😄

@nnsnodnb
Copy link
Copy Markdown
Contributor Author

Thank you for resolving.
I have rebased it, so please check again.

Copy link
Copy Markdown
Owner

@mpeteuil mpeteuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for updating these!

@mpeteuil mpeteuil merged commit 9b74d55 into mpeteuil:main Nov 12, 2023
@nnsnodnb nnsnodnb deleted the update-ci branch November 12, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants