fix: Correct file name in web-ext submit in Node 24#3466
Merged
Rob--W merged 1 commit intomozilla:masterfrom Jul 10, 2025
Merged
fix: Correct file name in web-ext submit in Node 24#3466Rob--W merged 1 commit intomozilla:masterfrom
Rob--W merged 1 commit intomozilla:masterfrom
Conversation
rpl
approved these changes
Jul 10, 2025
Member
rpl
left a comment
rpl
left a comment
There was a problem hiding this comment.
@Rob--W lgtm! ❤️ thanks for digging deep into the reasons behind this regression hit on Node 24 (and for having looked as far as to find a reasonable workaround that would work also for nodejs >= 18 while that nodejs version is still in the supported range in the web-ext manifest and part of our CI job).
klappradla
added a commit
to bitcrowd/tickety-tick
that referenced
this pull request
Oct 27, 2025
There's a bug in previous web-ext packages which make them incompatible with current versions of NodeJS. So we need version 8.9.0 in order to craft a release. See: - mozilla/web-ext#3418 - mozilla/web-ext#3466 - https://github.com/mozilla/web-ext/releases/tag/8.9.0
klappradla
added a commit
to bitcrowd/tickety-tick
that referenced
this pull request
Oct 27, 2025
There's a bug in previous web-ext packages which make them incompatible with current versions of NodeJS. So we need version 8.9.0 in order to craft a release. See: - mozilla/web-ext#3418 - mozilla/web-ext#3466 - https://github.com/mozilla/web-ext/releases/tag/8.9.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3418.
For context, see #3418 (comment)