Update dependency react-router-dom to v7

[renovate]

This PR contains the following updates:

Package	Change	Age	Confidence
react-router-dom (source)	6.28.2 → 7.13.1

---

Release Notes

remix-run/react-router (react-router-dom)

v7.13.1

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.13.0

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.12.0

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.11.0

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.10.1

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.10.0

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.9.6

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.9.5

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.9.4

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.9.3

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.9.2

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.9.1

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.9.0

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.8.2

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.8.1

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.8.0

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.7.1

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.7.0

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.6.3

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.6.2

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.6.1

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.6.0

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.5.3

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.5.2

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.5.1

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.5.0

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.4.1

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.4.0

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.3.0

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.2.0

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.1.5

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.1.4

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.1.3

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.1.2

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.1.1

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.1.0

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.0.2

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.0.1

Compare Source

Patch Changes

• Updated dependencies:
  • [email protected]

v7.0.0

Compare Source

Major Changes

• Remove the original defer implementation in favor of using raw promises via single fetch and turbo-stream. This removes these exports from React Router: (#​11744)

  • defer
  • AbortedDeferredError
  • type TypedDeferredData
  • UNSAFE_DeferredData
  • UNSAFE_DEFERRED_SYMBOL,

• Use createRemixRouter/RouterProvider in entry.client instead of RemixBrowser (#​11469)

• Remove single fetch future flag. (#​11522)

• Remove future.v7_startTransition flag (#​11696)

• Remove future.v7_normalizeFormMethod future flag (#​11697)

• Allow returning undefined from actions and loaders (#​11680)

• update minimum node version to 18 (#​11690)

• Remove future.v7_prependBasename from the ionternalized @remix-run/router package (#​11726)

• Remove future.v7_throwAbortReason from internalized @remix-run/router package (#​11728)

• Add exports field to all packages (#​11675)

• node package no longer re-exports from react-router (#​11702)

• updates the minimum React version to 18 (#​11689)

• • Remove the future.v7_partialHydration flag (#​11725)
    • This also removes the <RouterProvider fallbackElement> prop
      • To migrate, move the fallbackElement to a hydrateFallbackElement/HydrateFallback on your root route
    • Also worth nothing there is a related breaking changer with this future flag:
      • Without future.v7_partialHydration (when using fallbackElement), state.navigation was populated during the initial load
      • With future.v7_partialHydration, state.navigation remains in an "idle" state during the initial load

• Remove future.v7_fetcherPersist flag (#​11731)

Minor Changes

• Add prefetching support to Link/NavLink when using Remix SSR (#​11402)
• Enhance ScrollRestoration so it can restore properly on an SSR'd document load (#​11401)
• Add built-in Remix-style hydration support to RouterProvider. When running from a Remix-SSR'd HTML payload with the proper window variables (__remixContext, __remixManifest, __remixRouteModules), you don't need to pass a router prop and RouterProvider will create the router for you internally. (#​11396) (#​11400)

Patch Changes

• Memoize some RouterProvider internals to reduce uneccesary re-renders (#​11817)
• Updated dependencies:
  • [email protected]

v6.30.3

Compare Source

v6.30.2

Compare Source

v6.30.1

Compare Source

v6.30.0

Compare Source

v6.29.0

Compare Source

---

Configuration

📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[jmaher]

@beatrice-acasandrei @alexandru-io this is failing on a perf test, can you put this in the perfherder queue to fix the test and upgrade the package?

[jmaher]

@alexandru-io I asked 6 months ago for this to be looked into as it is blocked on a perfherder test, can we make this a higher priority?

[alexandru-io]

Sorry @jmaher we'll look into it with higher priority.
cc @beatrice-acasandrei

[beatrice-acasandrei]

Hi @jmaher! We looked into upgrading React Router Dom to V6, but we have some concerns.
There are many breaking changes, one that stands out the most is that React Router Dom isn't able to support class components because they can't use React hooks. Unfortunately for us in the codebase most of the react components are classes. It affects both Treeherder and Perfherder and it’s not trivial to fix. At the end it should be deployed to prototype and tested rigorously by us and perhaps multiple users. Because of this we are also trying to establish a migration strategy.

Because it’s not trivial and it also affects Treeherder, is there maybe someone that can help us with the upgrade? We think this will take some time to accomplish and we’ll need to prioritize our tasks. Please let us know what your thoughts are.

Files that need to be updated:
ui/App.jsx
ui/intermittent-failures/App.jsx
ui/perfherder/App.jsx
ui/push-health/App.jsx

Some resources:
https://reactrouter.com/en/main/upgrading/v5
https://stackoverflow.com/questions/74239145/react-router-dom-v6-does-v6-support-for-class-components
https://stackoverflow.com/questions/70443591/how-to-pass-props-using-element-in-react-router-v6

[jmaher]

thanks for reaching out, Right now this patch is failing on perfherder tests, so possibly if you could add a fix for the perfherder tests (and code as needed), we could pick up the related work/testing for treeherder proper.

[beatrice-acasandrei]

thanks for reaching out, Right now this patch is failing on perfherder tests, so possibly if you could add a fix for the perfherder tests (and code as needed), we could pick up the related work/testing for treeherder proper.

@jmaher There's no quick fix for this, the tests are not the issue here. The update from V6 affects the routes, without fixing them properly everything is busted.

We tried locally to upgrade to v6 and fixing the errors, that's when we realized all of the above. Currently we are looking into a compatibility package that will allow us to migrate incrementally to V6.

[jmaher]

are you saying in order to get the tests working for perfherder you need to fix treeherder routes as well, not just perfherder routes? I would expect some other tests to fail if there were more fixes, but that could be a sign of poor tests

[jmaher]

testing this current PR locally (via yarn start) yields a treeherder that I can view results and add/remove filters as well as annotate failures. While I didn't test everything, it seems that the large majority of the functionality works. I suspect all that needs to happen is fix the perfherder tests and maybe a route or two within perfherder.

[beatrice-acasandrei]

testing this current PR locally (via yarn start) yields a treeherder that I can view results and add/remove filters as well as annotate failures. While I didn't test everything, it seems that the large majority of the functionality works. I suspect all that needs to happen is fix the perfherder tests and maybe a route or two within perfherder.

@jmaher Because package.json is affected I recommend deleting node_modules and then running yarn install. Currently everything is working for you because you have the react router dom v5 installed I assume, not v6. You could also check the version installed before running yarn start to make sure the changes from this PR are applied.

[beatrice-acasandrei]

are you saying in order to get the tests working for perfherder you need to fix treeherder routes as well, not just perfherder routes? I would expect some other tests to fail if there were more fixes, but that could be a sign of poor tests

Yes, that's what I was trying to explain. I'm not sure why the other tests are not failing.