Optimize more for the empty case #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gankra
approved these changes
Aug 23, 2022
Collaborator
Gankra
left a comment
Gankra
left a comment
There was a problem hiding this comment.
seems good, just two nits
Collaborator
|
Also there's something very funny about me having spent a fair amount of time carefully crafting code that works the same for the singleton and non-singleton case without UB and now you show up and go "actually it's faster to wrap everything in a fast-path guard against the singleton case" 🥲 |
nnethercote
force-pushed
the
opt-for-empty-case
branch
from
522d47f to
fdb6b2e
Compare
Contributor
Author
|
Ok, review comments addressed. Thanks for the fast review. |
Collaborator
|
v0.2.8 published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits optimize several operations better for the case where the
ThinVecis empty. This is a common case for my use case of interest (inrustc) and is likely a pretty common case forThinVecin general. (More so thanVec, for example.) It does slightly pessimize the non-empty cases, but only to the tune of a single branch per operation, which is hopefully acceptable.