Declarative Shadow DOM (positive) #740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tantek
requested changes
Jan 26, 2023
Member
tantek
left a comment
tantek
left a comment
There was a problem hiding this comment.
This looks like a good updated summary except I think for a WHATWG spec change like this it would be better to link 'url' to the primary spec PR rather than the explainer. E.g.
"url": "https://github.com/whatwg/html/pull/5465"
Note that spec PR itself links at the top of its explanation to the Explainer, and the DOM spec PR, so everything is easily discoverable from there, which is not true with the Explainer.
zcorpan
commented
Jan 26, 2023
Member
Author
|
@tantek good point, fixed. |
tantek
approved these changes
Jan 27, 2023
hsivonen
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #335