Follow-up to #16971 / #16993.
drop_documentation_link_title_errors in experimenter/nimbus_ui/new/views.py strips title errors from every documentation link in the review errors, not just the blank link that was just added via "+Add link". Since the same mutated field_errors feeds both the Overview card and the sidebar setup issues, a genuine title error becomes invisible everywhere.
Steps to reproduce
- On a draft rollout, add a documentation link with a valid URL but leave the title unset.
- Open the rollout detail page.
Actual result
The review serializer reports an error:
[{'title': [ErrorDetail(string='"" is not a valid choice.', code='invalid_choice')]}]
but nothing is shown in the Overview card or the sidebar setup issues. The rollout appears fully set up.
Expected result
A readable error on that link (something like "Please select a link type"), and the issue counted in the setup progress, so the rollout is not sent to review in a state that will be rejected.
Notes
The suppression is only needed for links that are entirely blank — those already show "This field may not be blank." Scoping it to fully-blank rows would keep the #16971 fix and close this gap.
┆Issue is synchronized with this Jira Task
Follow-up to #16971 / #16993.
drop_documentation_link_title_errorsinexperimenter/nimbus_ui/new/views.pystripstitleerrors from every documentation link in the review errors, not just the blank link that was just added via "+Add link". Since the same mutatedfield_errorsfeeds both the Overview card and the sidebar setup issues, a genuine title error becomes invisible everywhere.Steps to reproduce
Actual result
The review serializer reports an error:
but nothing is shown in the Overview card or the sidebar setup issues. The rollout appears fully set up.
Expected result
A readable error on that link (something like "Please select a link type"), and the issue counted in the setup progress, so the rollout is not sent to review in a state that will be rejected.
Notes
The suppression is only needed for links that are entirely blank — those already show "This field may not be blank." Scoping it to fully-blank rows would keep the #16971 fix and close this gap.
┆Issue is synchronized with this Jira Task