chore(parsing): Allow parsing to continue on unrecognized file #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because: - Some file names might sneak into GCP that the tool cannot parse This Commit: - Updates the error handling to just log unparsable files as warning, preventing total exit and allowing continued processing
nshirley
force-pushed
the
chore/dont-fail-on-unprased-file
branch
from
4636c10 to
50da258
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This Commit:
Description
Because of the order and current handling of file parsing, if a file with a bad name exists it can kill the process and cause it to immediately exit. This commit just updates the logic to log those as warnings, allowing it to continue on.
Issues
Closes: N/A