Skip to content

Bump node versions#5675

Merged
willdurand merged 2 commits intomasterfrom
node-version
Sep 22, 2025
Merged

Bump node versions#5675
willdurand merged 2 commits intomasterfrom
node-version

Conversation

@willdurand
Copy link
Member

@willdurand willdurand commented May 27, 2025

I disabled a step for now, hoping to re-enable it when mozilla/web-ext#3429 has been fixed.

@willdurand willdurand marked this pull request as ready for review September 19, 2025 13:13
@willdurand willdurand requested a review from rpl September 19, 2025 13:14
@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.78%. Comparing base (b8a73e4) to head (5fb1715).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5675   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files          51       51           
  Lines        2882     2882           
  Branches      883      883           
=======================================
  Hits         2847     2847           
  Misses         35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@willdurand
Copy link
Member Author

I disabled a step for now, hoping to re-enable it when mozilla/web-ext#3429 has been fixed.

I confirmed that mozilla/web-ext#3519 would "fix" this failure.

@willdurand
Copy link
Member Author

I filed #5794 to re-enable the step later.

Copy link
Member

@rpl rpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, as we already agreed this is disabling just the CI task running the web-ext functional tests (which is mainly used to catch potential regressions on integrating new addons-linter version in the web-ext cli tool) as short term workaround to unblock bumping the nodejs version in this repository (and then soon enough we will re-enable it, once we have fixed the underlying issue on the web-ext side).

@willdurand willdurand merged commit 3fac96b into master Sep 22, 2025
4 checks passed
@willdurand willdurand deleted the node-version branch September 22, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants