fix: propagate env vars to child processes

[repsac-by]

Propagates environment variables when starting and stopping child processes by appending instead of overwriting them.

Fixes: #168, #169

Summary by CodeRabbit

• Bug Fixes
  • Subprocesses now correctly inherit the full environment of the parent process along with any additional configured environment variables, ensuring more reliable and consistent behavior.

[coderabbitai]

Walkthrough

The changes update how environment variables are set for subprocesses in the Process struct. Instead of replacing the environment with only the configured variables, the subprocesses now inherit the parent process's environment and append any additional configuration-specified variables.

Changes

File(s)	Change Summary
proxy/process.go	Modified subprocess environment handling to append configured variables to the inherited environment instead of replacing it.

Sequence Diagram(s)

sequenceDiagram
    participant ParentProcess
    participant ProcessStruct
    participant Subprocess

    ParentProcess->>ProcessStruct: Configure environment variables (p.config.Env)
    ProcessStruct->>Subprocess: Start subprocess with inherited environment + p.config.Env
    Subprocess-->>ProcessStruct: Runs with combined environment

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Ensure subprocesses inherit parent environment plus configured variables (#168)	✅
Fix inability to launch Koboldcpp models due to environment issues (#168)	✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9963ae1 and b090a2a.

📒 Files selected for processing (1)

• proxy/process.go (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: run-tests

🔇 Additional comments (2)

proxy/process.go (2)

196-196: Excellent fix for environment variable propagation!

This change correctly inherits the parent process environment while allowing configuration-specific overrides. The subprocess will now have access to essential system variables like PATH, HOME, etc., plus any additional variables specified in p.config.Env.

---

534-534: Consistent environment handling for stop commands.

Good consistency - the stop command now also inherits the full parent environment plus configured variables, matching the behavior of the main command start process.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mostlygeek]

I just pushed #171 which has the exact same fix as you proposed. Thank you for identifying this issue and sending the PR. I'll land #171 instead as it includes additional tests and another testing bug I found.