Cannot override the ymin value when all y values are equal to ymin

[monicao]

When all y values in a data set are 0 the y-axis range is -1 to 1. I tried overriding the ymin value, but the change did not take effect because the ymin == ymax.

  Morris.Line({
    element: 'sales_chart',
    data: data['product_analytics'],
    xkey: 'time',
    ykeys: ['sales'],
    ymin: 0,
    labels: ['Total Sales'],
    smooth: false,
    preUnits: '$'
  });

Screenshot: http://d.pr/i/D5KY

[oesmith]

Try the latest master, I've slightly modified the ymin/ymax behaviour. FWIW, I recommend setting ymax to auto N in these situations (where N is a sensible number for your dataset).

[monicao]

Thanks for the quick fix. I was going to submit a pull request but you beat me to it. Really like morris.js so far.

[oesmith]

No problems - I'm glad it's working for you.

Cheers!

Olly

On 26 Sep 2012, at 21:47, Monica Olinescu notifications@github.com wrote:

Thanks for the quick fix. I was going to submit a pull request but you beat
me to it. Really like morris.js so far.

—
Reply to this email directly or view it on
GitHubhttps://github.com/oesmith/morris.js/issues/80#issuecomment-8905118.