Foundry v1.4 #42
Merged
Foundry v1.4 #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peyha
approved these changes
Oct 28, 2025
adhusson
requested changes
Oct 28, 2025
Contributor
adhusson
left a comment
adhusson
left a comment
There was a problem hiding this comment.
I would remove the struct style update. It's less easy to read & for Withdrawals, FlowCapsConfig does not increase safety because typing is enough. And for FlowCaps min->max is clear.
Comment on lines
-13
to
+17
| Id, IMorpho, IMetaMorpho, MarketAllocation, MarketParams | ||
| Id, | ||
| IMorpho, | ||
| IMetaMorpho, | ||
| MarketAllocation, | ||
| MarketParams |
Contributor
There was a problem hiding this comment.
single_line_imports config option is coming. Do we want to wait for it?
Contributor
Author
There was a problem hiding this comment.
I'm merging and we can come back to this later.
Btw I'm against because it requires another config parameter to add to the repos and it breaks the line length setting
adhusson
approved these changes
Oct 28, 2025
Contributor
adhusson
left a comment
adhusson
left a comment
There was a problem hiding this comment.
After discussion with Quentin it's worth having a consistent policy especially because it avoids having to remember to change the convention when stricts are updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.