Adding cancellation token support.#147
Merged
adamhewitt627 merged 1 commit intomoq:masterfrom May 31, 2022
Keboo:handleCancellationTokens
Merged
Adding cancellation token support.#147adamhewitt627 merged 1 commit intomoq:masterfrom Keboo:handleCancellationTokens
adamhewitt627 merged 1 commit intomoq:masterfrom
Keboo:handleCancellationTokens
Conversation
There are a few changes here: 1. This adds a new resolver to automatically handle CancellationToken. Defaults to CancellationToken.None, but will use injected tokens or CancellationTokenSources to resolve if they are present. 2. This drops the class generic constraint from the AutoMocker.Get<T> methods. This was initially in place because there is a class constraint on Moq.Mock<T>, however with resolvers it is perfectly valid to want to retrieve value types (such as CancellationToken). 3. The source generator was updated to not generate argument null tests for value types.
adamhewitt627
approved these changes
May 31, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few changes here: