Skip to content

Increase authoring duration to 2s and block weight limit x4#640

Merged
girazoki merged 5 commits intomasterfrom
tomasz-authoring-2s
Aug 5, 2024
Merged

Increase authoring duration to 2s and block weight limit x4#640
girazoki merged 5 commits intomasterfrom
tomasz-authoring-2s

Conversation

@tmpolaczyk
Copy link
Copy Markdown
Contributor

@tmpolaczyk tmpolaczyk commented Jul 31, 2024

Block authoring duration: 0.5s -> 2s
Frontier template gas limit: 15M -> 60M
Substrate block weight limit: 0.5e12 -> 2e12

paritytech/polkadot-sdk#5195

@tmpolaczyk tmpolaczyk added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Jul 31, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 31, 2024

Coverage Report

(master)

@@                  Coverage Diff                   @@
##           master   tomasz-authoring-2s     +/-   ##
======================================================
  Coverage   66.63%                66.63%   0.00%     
  Files         261                   261             
- Lines       44717                 44716      -1     
======================================================
  Hits        29794                 29794             
- Misses      14923                 14922      -1     
Files Changed Coverage
/node/src/service.rs 23.47% (+0.04%) 🔼

Coverage generated Thu Aug 1 10:16:03 UTC 2024

@tmpolaczyk
Copy link
Copy Markdown
Contributor Author

I see this comment in many places:

/// We allow for 0.5 of a second of compute with a 12 second average block time.
const MAXIMUM_BLOCK_WEIGHT: Weight = Weight::from_parts(
    WEIGHT_REF_TIME_PER_SECOND.saturating_div(2),
    cumulus_primitives_core::relay_chain::MAX_POV_SIZE as u64,
);

I guess we want to modify the weight so that it is equivalent to 2s of compute with 6s average block time?

@girazoki
Copy link
Copy Markdown
Contributor

girazoki commented Aug 1, 2024

Yes I think we can

@girazoki
Copy link
Copy Markdown
Contributor

girazoki commented Aug 1, 2024

Although before we do it, let's just see what other runtimes are doing

@girazoki
Copy link
Copy Markdown
Contributor

girazoki commented Aug 1, 2024

@tmpolaczyk
Copy link
Copy Markdown
Contributor Author

Let's try and see if anything breaks

@tmpolaczyk tmpolaczyk changed the title Increase authoring duration to 2s Increase authoring duration to 2s and block weight limit x4 Aug 1, 2024
@girazoki girazoki requested a review from fgamundi August 2, 2024 14:31
@girazoki girazoki merged commit 414cd1a into master Aug 5, 2024
@girazoki girazoki deleted the tomasz-authoring-2s branch August 5, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants