Limit block production to one block per slot in basic collator#456
Merged
Limit block production to one block per slot in basic collator#456
Conversation
Contributor
Coverage Report@@ Coverage Diff @@
## master agustin-fix-basic-collator-panic +/- ##
====================================================================
- Coverage 67.72% 67.56% -0.16%
Files 63 63
+ Lines 9143 9161 +18
====================================================================
- Hits 6192 6189 -3
+ Misses 2951 2972 +21
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following panic present in the logs:
As related to paritytech/polkadot-sdk#3308, it seems that with the current configuration of the basic collator, every para-block is attempted to be imported twice in the same slot, which is not the expected case with this "basic" kind of collator.