Assets xcm

[girazoki]

Adds pallet-assets, foreign-asset-creator and asset-rate as necessary pallets to mint derivative tokens coming from other chains, with these respective goals:

• pallet-assets: handle representation and assets of derivative tokens
• foreign-asset-creator: maintain a mapping between MultiLocation and assetId, which should make it easier to handle future ML versions.
• asset-rate: maintains the rate at which we can charge weight execution fees for certain tokens

TODO:

• update benchmakrs

For future PRs:

• Incorporate these into templates

[girazoki]

Modify

[github-actions]

Coverage Report

(master)

@@                   Coverage Diff                   @@
##           master   girazoki-assets-xcm      +/-   ##
=======================================================
+ Coverage   75.97%                76.35%   +0.38%     
+ Files          98                   101       +3     
+ Lines       24568                 25092     +524     
=======================================================
+ Hits        18665                 19158     +493     
+ Misses       5903                  5934      +31     

Files Changed	Coverage
/client/consensus/src/consensus_orchestrator.rs	77.90% (+0.44%)	🔼
/pallets/services-payment/src/lib.rs	84.56% (+0.67%)	🔼
/runtime/dancebox/src/lib.rs	81.07% (-0.16%)	🔽
/runtime/dancebox/src/weights/xcm/mod.rs	17.89% (+3.15%)	🔼
/runtime/dancebox/src/weights/xcm/pallet_xcm_benchmarks_generic.rs	11.36% (+1.59%)	🔼
/runtime/dancebox/tests/integration_test.rs	99.71% (+0.01%)	🔼
/runtime/flashbox/src/lib.rs	43.93% (+0.31%)	🔼

Coverage generated Wed Jan 17 14:52:47 UTC 2024

[Agusrodri]

I didn't see anything that could block the PR. Although I think we should keep an eye on the runtime code that could be moved to polkadot-sdk, like the one related to NativeAssetReserve for instance. Also a follow up task would be to add some TS tests (the rust ones look great). Other than those comments LGTM!

[girazoki]

thank Agustin! Yeah I will add a few more tests in TS for sure before I merge this PR

[girazoki]

We need to update the benchmark for buy_execution but it is dependent on paritytech/polkadot-sdk#2962. So for now I think we can postpone this for a future PR