Enable 10 Mb PoV for moonbase and moonriver#3228
Merged
Conversation
Contributor
WASM runtime size check:Compared to target branchMoonbase runtime: 2424 KB (no changes) 🚨 Moonbeam runtime: 2404 KB (+4 KB) 🚨 Moonriver runtime: 2396 KB (no changes) ✅ Compared to latest release (runtime-3501)Moonbase runtime: 2424 KB (+472 KB compared to latest release) 🚨 Moonbeam runtime: 2404 KB (+464 KB compared to latest release) 🚨 Moonriver runtime: 2396 KB (+456 KB compared to latest release) |
RomarQ
added
B7-runtimenoteworthy
Contributor
Coverage Report@@ Coverage Diff @@
## master rq/increase-moonbase-max-pov +/- ##
===============================================================
Coverage 74.27% 74.27% 0.00%
Files 383 383
Lines 97131 97131
===============================================================
Hits 72137 72137
Misses 24994 24994
|
stiiifff
reviewed
Mar 25, 2025
RomarQ
changed the title
RomarQ
added
breaking
TarekkMA
approved these changes
Mar 26, 2025
manuelmauro
approved these changes
Mar 26, 2025
test/suites/dev/moonbase/test-xcm-v3/test-mock-hrmp-transact-ethereum-8.ts
Show resolved
Hide resolved
stiiifff
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Follow up of polkadot-fellows/runtimes#553
The changes contained in this PR centralize the
MAX_POV_SIZEin a single constant and enables 10 MB PoV formoonbaseandmoonriverruntimes.Also includes the following polkadot-sdk changes:
What important points should reviewers know?
gas per PoV ratiois now expected to be half, resulting in cheaper ethereum transactions when (PoV gas is the effective gas).proof_sizeworst case scenario inpallet-ethereum-xcmextrinsics has now doubled, because ofGasWeightMapping::gas_to_weight, which computes the proof size in the following way:let proof_size = gas.saturating_div(ratio). This is a worst case scenario which needs to be accounted since PoV gas is now cheaper.