Add pallet-collective instances benchmarks to all runtimes#3208
Merged
Add pallet-collective instances benchmarks to all runtimes#3208
Conversation
…s script now uses frame-omni-bencher and outputs to a folder instead of a file to support pallet instances.
Contributor
Moonbase Weight Difference Report
Moonriver Weight Difference Report
Moonbeam Weight Difference Report
|
Contributor
WASM runtime size check:Compared to target branchMoonbase runtime: 2428 KB (+8 KB) 🚨 Moonbeam runtime: 2404 KB (+4 KB) 🚨 Moonriver runtime: 2408 KB (-4 KB) 🚨 Compared to latest release (runtime-3501)Moonbase runtime: 2428 KB (+476 KB compared to latest release) 🚨 Moonbeam runtime: 2404 KB (+464 KB compared to latest release) 🚨 Moonriver runtime: 2408 KB (+468 KB compared to latest release) 🚨 |
RomarQ
added
B7-runtimenoteworthy
Contributor
Coverage Report@@ Coverage Diff @@
## master snowmead/pallet-collective-runtime-benchmarks +/- ##
=================================================================================
- Coverage 74.57% 74.37% -0.20%
+ Files 381 384 +3
+ Lines 96700 97044 +344
=================================================================================
+ Hits 72114 72174 +60
+ Misses 24586 24870 +284
|
RomarQ
previously approved these changes
Mar 7, 2025
RomarQ
reviewed
Mar 7, 2025
RomarQ
previously approved these changes
Mar 7, 2025
RomarQ
reviewed
Mar 7, 2025
RomarQ
reviewed
Mar 7, 2025
Co-authored-by: Rodrigo Quelhas <[email protected]>
RomarQ
approved these changes
Mar 7, 2025
stiiifff
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds pallet-collective instances benchmarks to all runtimes. Added a temporary workaround to support benchmarking different pallet instances until we upgrade polkadot-sdk.
Uses new frame-omni-bencher in
run-benches-for-runtime.shand now outputs to the weights directory instead of a specific pallet file to support pallet instances.Is there something left for follow-up PRs?
We should remove the workaround after our polkadot-sdk fork has been upgraded to stable2503.
The fix was done in this PR paritytech/polkadot-sdk#6435
We also need to benchmark both instances of pallet-collective:
pallet_collectiveandpallet_collective_open_tech_committee.