Benchmark instances of pallet-collective#3207
Closed
snowmead wants to merge 6 commits intomoonbeam-foundation:masterfrom
Closed
Benchmark instances of pallet-collective#3207snowmead wants to merge 6 commits intomoonbeam-foundation:masterfrom
pallet-collective#3207snowmead wants to merge 6 commits intomoonbeam-foundation:masterfrom
Conversation
…s directory for benching weights to support instances
RomarQ
reviewed
Mar 7, 2025
| [pallet_parameters, Parameters] | ||
| [pallet_xcm_weight_trader, XcmWeightTrader] | ||
| // pallet_collective instances | ||
| [pallet_collective, TreasuryCouncilCollective] |
Contributor
There was a problem hiding this comment.
Would be better to also rename this one:
Suggested change
| [pallet_collective, TreasuryCouncilCollective] | |
| [pallet_collective_treasury_council, TreasuryCouncilCollective] |
Comment on lines
+19
to
+26
| { | ||
| benchmark_type_aliases: { | ||
| $($bench_type_aliases:tt)* | ||
| } | ||
| custom_impls: { | ||
| $($custom:tt)* | ||
| } | ||
| } => { |
Contributor
There was a problem hiding this comment.
If we no longer need this, lets revert it. It will conflict with the changes I will add for the bridge mvp.
Contributor
Author
|
Opening PR from a non-fork |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds pallet-collective instances to all runtime benchmarks.
Added a temporary workaround to support benchmarking different pallet instances until we upgrade polkadot-sdk.
Is there something left for follow-up PRs?
We should remove the workaround after our polkadot-sdk fork has been upgraded to stable2503.
The fix was done in this PR paritytech/polkadot-sdk#6435
We also need to benchmark both instances of pallet-collective:
pallet_collectiveandpallet_collective_open_tech_committee.